8000 Upgrade libmachine to master by afbjorklund · Pull Request #4817 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Upgrade libmachine to master - #4817

#4817
Merged
afbjorklund merged 1 commit into
kubernetes:masterfrom
afbjorklund:machine-master
Jul 21, 2019
Merged

afbjorklund merged 1 commit into
kubernetes:masterfrom
afbjorklund:machine-master

Conversation

@afbjorklund
Copy link
Copy Markdown
Collaborator

This includes the fixes that was previously on
the github.com/machine-drivers/machine master:

6f34be4 Allow localized names for Virtual Switch (now docker-archive-public/docker.machine@5bc065d)
3a0d935 Fix broken IsVTXDisabled detection on AMD CPU (now docker-archive-public/docker.machine@173a41d)

$ git diff --stat v0.16.1 v0.16.1^-24-ga555e4f7a8f5
 MAINTAINERS                           | 13 +++++--------
 drivers/amazonec2/amazonec2.go        | 26 +++++++++++++++++++++-----
 drivers/amazonec2/region.go           |  1 +
 drivers/google/compute_util.go        |  2 +-
 drivers/google/google.go              | 44 +++++++++++++++++++++++++++-----------------
 drivers/hyperv/hyperv.go              |  4 ++--
 drivers/openstack/client.go           |  1 +
 drivers/openstack/openstack.go        | 24 ++++++++++++++++++++++++
 drivers/softlayer/softlayer.go        |  1 -
 drivers/virtualbox/vtx_intel.go       |  2 +-
 drivers/vmwarefusion/fusion_darwin.go |  2 +-
 libmachine/provision/arch.go          |  2 +-
 libmachine/provision/arch_test.go     |  4 ++--
 version/version.go                    |  2 +-
 14 files changed, 88 insertions(+), 40 deletions(-)

Unfortunately machine does not tag on master...

Hacked the go.mod, to make it less weird (v0.7.1?)

Closes #4816

This includes the fixes that was previously on
the github.com/machine-drivers/machine master:

6f34be4 Allow localized names for Virtual Switch
3a0d935 Fix broken IsVTXDisabled detection on AMD CPU
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@afbjorklund
afbjorklund requested review from tstromberg and removed request for RA489 July 19, 2019 12:14
@medyagh
medyagh commented Jul 19, 2019
Copy link
Copy Markdown
Member

Registry fail tests are related to : #4820

@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@medyagh
medyagh commented Jul 20, 2019
Copy link
Copy Markdown
Member

/retest this please

1 similar comment
@medyagh
medyagh commented Jul 20, 2019
Copy link
Copy Markdown
Member

/retest this please

@afbjorklund
afbjorklund merged commit bcf3597 into kubernetes:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to start VM - This computer doesn't have VT-X/AMD-v enabled

4 participants

0