8000 Fix regression caused by registry-proxy by kumarom · Pull Request #4805 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fix regression caused by registry-proxy - #4805

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
kumarom:registry-proxy-fix
Jul 18, 2019
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
kumarom:registry-proxy-fix

Conversation

@kumarom
@kumarom kumarom commented Jul 18, 2019 •
Copy link
Copy Markdown
Contributor

This PR addresses #4604 by adding a new selector to concerned svc/rc only.
This also reverts kubernetes.io/minikube-addons to registy for registry-proxy
so that addon manager can deploy registry-proxy when registry addon is enabled.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 18, 2019
@k8s-ci-robot
8000 Copy link
Copy Markdown
Contributor

Hi @kumarom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 18, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kumarom
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

8000

@kumarom
kumarom force-pushed the registry-proxy-fix branch from 743c64f to 55cd455 Compare July 18, 2019 12:17
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jul 18, 2019
This PR addresses kubernetes#4604 by adding a new selector to concerned svc/rc only.
This also reverts `kubernetes.io/minikube-addons` to `registy` for registry-proxy
so that addon manager can deploy registry-proxy when registry addon is enabled.
@kumarom
kumarom force-pushed the registry-proxy-fix branch from 55cd455 to d76d874 Compare July 18, 2019 12:58
@tstromberg
Copy link
Copy Markdown
Contributor

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0