Repository navigation
Fix regression caused by registry-proxy - #4805
Conversation
|
Hi @kumarom. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kumarom The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
743c64f to
55cd455
Compare
This PR addresses kubernetes#4604 by adding a new selector to concerned svc/rc only. This also reverts `kubernetes.io/minikube-addons` to `registy` for registry-proxy so that addon manager can deploy registry-proxy when registry addon is enabled.
55cd455 to
d76d874
Compare
|
Thank you for fixing this! |
This PR addresses #4604 by adding a new selector to concerned svc/rc only.
This also reverts
kubernetes.io/minikube-addonstoregistyfor registry-proxyso that addon manager can deploy registry-proxy when registry addon is enabled.