Repository navigation
Add warn if kvm driver version is old - #4676
Conversation
|
Can one of the admins verify this patch? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: josedonizetti The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ab260b8 to
8a4bf13
Compare
|
@medyagh Let me know what you think about the changes. I've added a constant to the kvm documentation, we could start enforcing it everywhere we link to the documentation, that way if we need to change one day, it's a single change. I'll try to simplify the documentation now. Although I'm intrigued the PR #4681 make this one unnecessary. |
|
I think this PR could be used to detect the too old KVM drivers that we want to enforce the upgrade ( before the user waits a few minutes till the error happen) if we know the kvm driver is too old. we should end gracefuly without error. the other PR is good when minikube crashes with an error. it is meant as an after-happened handling, so we have less support ticket. so this is PR is still helpful and needed to detect sooner |
b2e409e to
4f3a83c
Compare
|
@medyagh I've added an upgrade section to the KVM documentation. I know you mentioned we had too many |
1136529 to
bbdb1a7
Compare
bbdb1a7 to
4cce597
Compare
|
@minikube-bot OK to test |
issue: #4658