8000 Universally redirect stdlog messages to glog by tstromberg · Pull Request #4562 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Universally redirect 8000 stdlog messages to glog - #4562

Merged
tstromberg merged 3 commits into
masterfrom
demo
Jun 24, 2019
Merged

tstromberg merged 3 commits into
masterfrom
demo

Conversation

@tstromberg
@tstromberg tstromberg commented Jun 23, 2019 •
Copy link
Copy Markdown
Contributor

selectImageRepository() was noisy due to go-containerregistry lookups. This was hitting a different set of calls than what we had already masked in cache_images.go. This makes it universal for all libraries.

The code was based on glog.CopyStandardLogTo(), except that the upstream version also copies the message to stdout, which is what we are trying to avoid.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2019
@tstromberg
tstromberg merged commit a702ce6 into master Jun 24, 2019
@medyagh
medyagh deleted the demo branch November 6, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0