8000 Allow --kubernetes-version to be specified without the leading v by tstromberg · Pull Request #4568 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Allow --kubernetes-version to be specified without the leading v - #4568

Merged
tstromberg merged 2 commits into
masterfrom
allow-naked-version
Jun 24, 2019
Merged

tstromberg merged 2 commits into
masterfrom
allow-naked-version

Conversation

@tstromberg
@tstromberg tstromberg commented Jun 24, 2019 •
Copy link
Copy Markdown
Contributor

I bumped into this issue when preparing for the demo at KubeCon.

With this PR, minikube allows both --kubernetes-version=v1.15.0 and --kubernetes-version=1.15.0. Otherwise, it fails later when it tries to cache images.

This PR was inspired by @dimitropoulos's work in #3766 - but rather than raising an early error if v is omitted, allows both formats.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2019
@sharifelgamal
Copy link
Copy Markdown
Contributor

This looks fine once the lint error is fixed. Apparently there's a testDataDir that's not used somewhere.

@tstromberg
tstromberg merged commit e851619 into master Jun 24, 2019
@medyagh
medyagh deleted the allow-naked-version branch November 6, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0