8000 Add docs for registry proxy addon by kumarom · Pull Request #4539 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add docs for registry proxy addon - #4539

Merged
medyagh merged 3 commits into
kubernetes:masterfrom
kumarom:registry-proxy
Jun 24, 2019
Merged

medyagh merged 3 commits into
kubernetes:masterfrom
kumarom:registry-proxy

Conversation

@kumarom
@kumarom kumarom commented Jun 20, 2019 •
Copy link
Copy Markdown
Contributor

This commit adds documentation on how to use minikube addon registry.
Related to #4341 and #4529
This addresses #4531 and #4242

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 20, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @kumarom. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kumarom
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested review from RA489 and balopat June 20, 2019 10:04
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

kumarom added 2 commits June 20, 2019 15:42
This commit adds documentation on how to use minikube addon registry.
Related to kubernetes#4341 and kubernetes#4529
This addresses kubernetes#4531 and kubernetes#4242
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 20, 2019
@medyagh medyagh left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding documentation, just small nit picks


Another approach is to enable minikube registry addons and then push images directly into registry. Steps for this approach is as follows:

Ensure that docker is configured to use `192.168.39.0/24` as insecure registry. Refer [here](https://docs.docker.com/registry/insecure/) for instructions.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this IP same on windows, mac on different drivers ... ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will explain how to decide what subnet to use here.

Comment thread docs/reusing_the_docker_daemon.md Outdated

Remember to turn off the _imagePullPolicy:Always_, as otherwise Kubernetes won't use images you built locally.

Another approach is to enable minikube registry addons and then push images directly into registry. Steps for this approach is as follows:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please make a heading so it is clear at the first look that this is the second method ?

maybe have the following headiings:

Reusing the Docker daemon

Method 1 : using ...

method: 2 : using...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do..

@medyagh medyagh changed the title Registry proxy Documentation for registry proxy addon Jun 20, 2019
@medyagh medyagh changed the title Documentation for registry proxy addon Add docs for registry proxy addon Jun 20, 2019
Explain how to decide what subnet to use.
Split into two headings.
Now run it in minikube:

```shell
kubectl run test-img --image=$(minikube ip):5000/test-img
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl run a Deployment is deprecated, maybe you can use kubectl create or kubectl run a Pod

@hyponet
hyponet commented Jun 24, 2019
Copy link
Copy Markdown

The "registry host" is indeed easy to misunderstand,this PR is very useful,thinks for you work!

@medyagh
medyagh merged commit 550218e into kubernetes:master Jun 24, 2019
@kumarom
kumarom deleted the registry-proxy branch June 25, 2019 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0