8000 Switch kubectl current-context on profile change by medyagh · Pull Request #4504 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Switch kubectl current-context on profile change - #4504

Merged
sharifelgamal merged 5 commits into
kubernetes:masterfrom
medyagh:profile_context_4503
Jun 18, 2019
Merged

sharifelgamal merged 5 commits into
kubernetes:masterfrom
medyagh:profile_context_4503

Conversation

@medyagh
@medyagh medyagh commented Jun 16, 2019 •
Copy link
Copy Markdown
Member

closes #4503

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a P 8000 R that changes 30-99 lines, ignoring generated files. labels Jun 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2019
@medyagh medyagh changed the title set kubectl current context on profile change Change kubectl current-context on profile change Jun 16, 2019
@medyagh medyagh changed the title Change kubectl current-context on profile change Switch kubectl current-context on profile change Jun 16, 2019
@medyagh
medyagh commented Jun 16, 2019
Copy link
Copy Markdown
Member Author

@minikube-bot OK to test

@sharifelgamal
sharifelgamal merged commit 35bbace into kubernetes:master Jun 18, 2019
@medyagh
medyagh deleted the profile_context_4503 branch November 6, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: setting minikube profile should set k8s current context .

3 participants

0