8000 Fixing file path for windows by medyagh · Pull Request #4434 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fixing file path for windows - #4434

Merged
sharifelgamal merged 2 commits into
kubernetes:masterfrom
medyagh:4433_filepath
Jun 6, 2019
Merged

sharifelgamal merged 2 commits into
kubernetes:masterfrom
medyagh:4433_filepath

Conversation

@medyagh
@medyagh medyagh commented Jun 6, 2019
Copy link
Copy Markdown
Member

fixes #4433

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @medyagh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: medyagh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2019
@medyagh
medyagh commented Jun 6, 2019
Copy link
Copy Markdown
Member Author

@minikube-bot okay to test

1 similar comment
@medyagh
medyagh commented Jun 6, 2019
Copy link
Copy Markdown
Member Author

@minikube-bot okay to test

@medyagh
medyagh commented Jun 6, 2019
Copy link
Copy Markdown
Member Author

@minikube-bot OK test

@medyagh medyagh added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2019
@medyagh
medyagh removed the request for review from balopat June 6, 2019 02:46
@sharifelgamal
sharifelgamal merged commit 53e8f9d into kubernetes:master Jun 6, 2019
@medyagh
medyagh deleted the 4433_filepath branch June 6, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing Test Windows: File Path

3 participants

0