8000 Dashboard: add --disable-settings-authorizer to avoid settings 403 forbidden by fenglixa · Pull Request #4405 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Dashboard: add --disable-settings-authorizer to avoid settings 403 forbidden - #4405

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
fenglixa:fix-4367
Jun 5, 2019
Merged

k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
fenglixa:fix-4367

Conversation

@fenglixa
@fenglixa fenglixa commented Jun 2, 2019 •
Copy link
Copy Markdown
Contributor

Before code change, reproduced the issue:
image

Code changed, the issue is gone:
image
image

  • Build & Test PASS:
    image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2019
@k8s-ci-robot
k8s-ci-robot requested review from RA489 and afbjorklund June 2, 2019 14:28
@RA489
RA489 commented Jun 2, 2019
Copy link
Copy Markdown

@minikube-bot OK to test

@afbjorklund
Copy link
Copy Markdown
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2019
@medyagh
medyagh commented Jun 5, 2019
Copy link
Copy Markdown
Member

/ok-to-test

@medyagh medyagh added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 5, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: fenglixa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit d556d58 into kubernetes:master Jun 5, 2019
@fenglixa
fenglixa deleted the fix-4367 branch June 5, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

0