8000 Add solution text for common kvm2 and VirtualBox problems by tstromberg · Pull Request #4198 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Add solution text for common kvm2 and VirtualBox problems - #4198

Merged
tstromberg merged 6 commits into
kubernetes:masterfrom
tstromberg:libvirt-solutions
May 3, 2019
Merged

tstromberg merged 6 commits into
kubernetes:masterfrom
tstromberg:libvirt-solutions

Conversation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2019
@k8s-ci-robot
k8s-ci-robot requested review from balopat and dlorenc May 2, 2019 23:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 2, 2019
@tstromberg tstromberg changed the title Add solution pop-up for common kvm2 and VirtualBox problems Add solution text for common kvm2 and VirtualBox problems May 2, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2019
Comment thread pkg/minikube/problem/err_map.go Resolved
@RA489
RA489 commented May 3, 2019
Copy link
Copy Markdown

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RA489, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

New changes are detected. LGTM label has been removed.

@tstromberg
tstromberg force-pushed the libvirt-solutions branch from 247a85d to 32f470f Compare May 3, 2019 19:12
@tstromberg
tstromberg merged commit d46decf into kubernetes:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0