8000 BugFix: ExecRunner.Copy now parses permissions strings as octal by marcosdiez · Pull Request #4139 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

BugFix: ExecRunner.Copy now parses permissions strings as octal - #4139

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
marcosdiez:proper_permissions
Apr 25, 2019
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
marcosdiez:proper_permissions

Conversation

@marcosdiez
@marcosdiez marcosdiez commented Apr 23, 2019 •
Copy link
Copy Markdown
Contributor

I actually fix two things here.
First, ExecRunner.Copy was parsing permissions as decimal integers instead of octal integers, which was giving odd results.

Second, for me it seems that /usr/bin/kubeadm and /usr/bin/kubelet should have 0755 instead of 0641

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @marcosdiez. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcosdiez
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@tstromberg
tstromberg merged commit b2f0cd8 into kubernetes:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0