8000 Assert that docker has started rather than explicitly restarting it by mdiez-modus · Pull Request #4114 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Assert that docker has started rather than explicitly restarting it - #4114

Closed
mdiez-modus wants to merge 2 commits into
kubernetes:masterfrom
marcosdiez:decrease_startup_time_10_seconds
Closed

mdiez-modus wants to merge 2 commits into
kubernetes:masterfrom
marcosdiez:decrease_startup_time_10_seconds

Conversation

@mdiez-modus
Copy link
Copy Markdown

I am not sure why we restart instead of start docker.

I mean, do we expect it to be in a broken state ?

Removing this 16 bits from the code made things start 10 seconds quicker.

I am not sure if restart is needed for other drivers.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 18, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @mdiez-modus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 18, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdiez-modus
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdiez-modus mdiez-modus changed the title Speedup load time in 10 seconds Speedup load time in 10 seconds on Docker Apr 18, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Copy Markdown
Contributor

/ok-to-test

@tstromberg tstromberg changed the title Speedup load time in 10 seconds on Docker Assert that docker has started rather than explicitly restarting it Apr 18, 2019
@tstromberg
Copy link
Copy Markdown
Contributor

Looks good - though I will admit I don't know what side effects to expect from this - such as modifications to --docker-env. Let's see if the tests uncover anything interesting.

This will also require an update to cruntime_test.go so that make test passes.

@mdiez-modus
Copy link
Copy Markdown
Author

PR created with my work user. Sorry. I have to open it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0