Repository navigation
Assert that docker has started rather than explicitly restarting it - #4114
mdiez-modus wants to merge 2 commits into
Conversation
|
Hi @mdiez-modus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mdiez-modus If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
|
/ok-to-test |
|
Looks good - though I will admit I don't know what side effects to expect from this - such as modifications to --docker-env. Let's see if the tests uncover anything interesting. This will also require an update to cruntime_test.go so that make test passes. |
|
PR created with my work user. Sorry. I have to open it again. |
I am not sure why we
restartinstead ofstartdocker.I mean, do we expect it to be in a broken state ?
Removing this 16 bits from the code made things start 10 seconds quicker.
I am not sure if
restartis needed for other drivers.