Repository navigation
Conversation
tstromberg
approved these changes
Apr 17, 2019
tstromberg
approved these changes
Apr 17, 2019
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: balopat, RA489 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
@minikube-bot OK to test |
Contributor
|
New changes are detected. LGTM label has been removed. |
Just need to add some more waiting in the integration test. Functionally everything was sound. Now the integration test waits up to 1 minute to see if the service ingress IP gets patched by
minikube tunnel. Fixes #3873.