8000 Avoid surfacing "error: no objects passed to apply" non-error from addon-manager by sharifelgamal · Pull Request #4076 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Avoid surfacing "error: no objects passed to apply" non-error from addon-manager - #4076

Merged
tstromberg merged 1 commit into
kubernetes:masterfrom
sharifelgamal:4010
Apr 10, 2019
Merged

tstromberg merged 1 commit into
kubernetes:masterfrom
sharifelgamal:4010

Conversation

@sharifelgamal
Copy link
Copy Markdown
Contributor

Fixes #4010

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @sharifelgamal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 10, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sharifelgamal
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: priyawadhwa

If they are not already assigned, you can assign the PR to them by writing /assign @priyawadhwa in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tstromberg tstromberg changed the title Avoid surfacing spurious errors Avoid surfacing "error: no objects passed to apply" non-error from addon-manager Apr 10, 2019
@tstromberg
tstromberg merged commit f265a22 into kubernetes:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0