8000 Fixed status checking with non-default apiserver-port. by moduspwnens · Pull Request #4058 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Fixed status checking with non-default apiserver-port. - #4058

Merged
tstromberg merged 2 commits into
kubernetes:masterfrom
moduspwnens:master
Apr 8, 2019
Merged

tstromberg merged 2 commits into
kubernetes:masterfrom
moduspwnens:master

Conversation

@moduspwnens
Copy link
Copy Markdown
Contributor

This is a fix for #4057.

Component health checking as part of "start" and "status" now respect non-default apiserver port settings from the command line and kubeconfig file, respectively. The functionality is now verified with an integration test.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @moduspwnens. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 5, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: moduspwnens
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: tstromberg

If they are not already assigned, you can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@moduspwnens
Copy link
Copy Markdown
Contributor Author

/assign @tstromberg

"kubeadm.ignore-preflight-errors=SystemVerification",
}},
{"apiserver_port_non_default", []string{
"--apiserver-port=8444",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind combining this with another test entry - such as "containerd"?

This is less than ideal, but each entry adds about 10 minutes to our integration tests.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I've now pushed a new commit that combines the two tests.

@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Copy Markdown
Contributor

Looks great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0