8000 Update Hyper-V daemons by laozc · Pull Request #4030 · kubernetes/minikube · GitHub
[go: up one dir, main page]

Skip to content

Update Hyper-V daemons - #4030

Merged
tstromberg merged 6 commits into
kubernetes:masterfrom
laozc:fix-hv-daemon
Apr 10, 2019
Merged

tstromberg merged 6 commits into
kubernetes:masterfrom
laozc:fix-hv-daemon

Conversation

@laozc
@laozc laozc commented Apr 1, 2019
Copy link
Copy Markdown
Member

Currently only KVP daemons are complied and installed into the minikube ISO.
There are a few more Hyper-V daemons for integration services needed like Fcopy and VSS.
This PR includes new configuration to enable these daemons in minikube.

  • Guest service is not enabled by default. Once it's checked in Hyper-V setting, the Fcopy daemon will be brought up by systemd, in which case you may leverage FCopy cmdlet to copy file into the VM

laozc added 6 commits March 30, 2019 19:20
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
Service restart may not work when a specific integration service
is disabled in the VM setting. Remove the setting for performance
concerns.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2019
@minikube-bot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Copy Markdown
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Copy Markdown
Contributor

Thank you!

@tstromberg
tstromberg merged commit 14414d1 into kubernetes:master Apr 10, 2019
@laozc
laozc deleted the fix-hv-daemon branch April 11, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0