[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply to become maintainers #5921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply to become maintainers #5921

wants to merge 1 commit into from

Conversation

JiaweiGithub
Copy link
Contributor

Signed-off-by: jiawei jiawei.liu@daocloud.io

What type of PR is this?
/kind documentation

What this PR does / why we need it:
I am the Chair and Technical Lead of sig network, and have participated in code reviews and problem-solving for modules such as edgemesh, device, and routerManager. I also participated in the design and development of some features, such as edgemesh deployment optimization, edgemesh cni support, device status reporting, and multilingual mapper. In addition, I often participate in community meetings and events, such as Open Source Summer 、lfx、academic Workshop。 In the future, I hope to continue to be deeply involved in the development of edgemesh and device related modules. My PR list is as follows:
https://github.com/kubeedge/kubeedge/pulls?q=is%3Apr+author%3AJiaweiGithub+is%3Aclosed
https://github.com/kubeedge/edgemesh/pulls?q=is%3Apr+author%3AJiaweiGithub+is%3Aclosed
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@JiaweiGithub
Apply to become maintainers
e3d48fc 
Signed-off-by: jiawei <jiawei.liu@daocloud.io>
@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign fisherxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 23, 2024
fisherxu
fisherxu reviewed Oct 24, 2024
View reviewed changes
Copy link
Member
@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for your contributions :)
/hold
Wait for more comments :)

@kubeedge-bot kubeedge-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 24, 2024
@benjaminhuo
Copy link

/lgtm

@kubeedge-bot
Copy link
Collaborator

@benjaminhuo: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@WillardHu
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2024
@kubeedge-bot
Copy link
Collaborator

@JiaweiGithub: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisherxu fisherxu fisherxu left review comments

@daixiang0 daixiang0 Awaiting requested review from daixiang0

@WillardHu WillardHu Awaiting requested review from WillardHu

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JiaweiGithub @kubeedge-bot @benjaminhuo @WillardHu @fisherxu