[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #11 #12

Merged
merged 8 commits into from
Apr 7, 2020
Merged

issue #11 #12

merged 8 commits into from
Apr 7, 2020

Conversation

luckylat
Copy link
Collaborator
@luckylat luckylat commented Apr 7, 2020

#11

@jpnykw jpnykw changed the title Dev issue #11 Apr 7, 2020
@jpnykw jpnykw self-requested a review April 7, 2020 07:01
jpnykw
jpnykw reviewed Apr 7, 2020
View reviewed changes
Copy link
Owner
@jpnykw jpnykw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log.rsはconsole.rsにしたほうが名前空間的に良い気がします（僕が修正しておきます）それ以外は完璧です

@jpnykw jpnykw merged commit b50c4f5 into jpnykw:master Apr 7, 2020
@jpnykw jpnykw added the enhancement New feature or request label Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnykw jpnykw jpnykw left review comments

Assignees

@jpnykw jpnykw

@luckylat luckylat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luckylat @jpnykw