[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report certain linter faults if they come from a macroexpansion located outside the :source-paths #394

Closed
vemv opened this issue May 24, 2021 · 0 comments · Fixed by the-benchmarker/web-frameworks#4464

Comments

@vemv
Copy link
Collaborator
vemv commented May 24, 2021

If a given linter fault, e.g. redundant (-> x) comes from a macroexpansion which macro is defined outside the :source-paths (typically [src test]), then the fault should not reported.

My reasoning is that typically:

  • these faults aren't an end user's fault
  • they typically don't matter, i.e. they're stylistic
  • muting them can require learning the disable-warning "DSL"
  • having them fixed upstream (that is, for the given 3rd-party lib defining the macro) is painful for everyone involved.

This silencing should be perfomed only for linters deemed "low-risk". There should be a way to opt out as well.


See also: #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant