8000 VariablePath: introduce a fake fallback value for a yet unknown init state by mwallnoefer · Pull Request #647 · jolie/jolie · GitHub
[go: up one dir, main page]
Skip to content

VariablePath: introduce a fake fallback value for a yet unknown init state - #647

Merged
fmontesi merged 1 commit into
masterfrom
fix/init-value
Feb 1, 2026
Merged

VariablePath: introduce a fake fallback value for a yet unknown init state#647
fmontesi merged 1 commit into
masterfrom
fix/init-value

Conversation

@mwallnoefer
@mwallnoefer mwallnoefer commented Dec 21, 2025
Copy link
Copy Markdown
Member

This allows to read it for the initalisation phase in order to address issue #625

@mwallnoefer mwallnoefer changed the title make the global init value accessible differently (issue #625) VariablePath: introduce a fake fallback value for a yet unknown init state Dec 21, 2025
@mwallnoefer
mwallnoefer marked this pull request as ready for review December 21, 2025 17:24
@mwallnoefer
mwallnoefer requested a review from fmontesi January 3, 2026 09:44
@Niels-Erik Niels-Erik mentioned this pull request Jan 3, 2026
Closed
@fmontesi
fmontesi commented Jan 15, 2026
Copy link
Copy Markdown
Member

Been following #625, should I wait further for this PR? It looks pretty safe at least, so I'm inclined to merge it in the meantime.

@mwallnoefer
mwallnoefer commented Jan 15, 2026
Copy link
Copy Markdown
Member Author

According to me this format = json (vs. the correct format = "json") is a parsing issue, which should better be denied and not silently ignored.

Otherwise the patch should work and we are able to remove this dirty getState() kludge. So I am very happy to see it merged.

@Niels-Erik
Niels-Erik commented Jan 15, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

According to me this format = json (vs. the correct format = "json") is a parsing issue, which should better be denied and not silently ignored.

This I agree with, otherwise if this is merged then an enhancement would be to give a warning to the programmer that a config was set to an uninitialized variable.

This is also what I tried to mention in #625.

@mwallnoefer
mwallnoefer commented Jan 23, 2026
Copy link
Copy Markdown
Member Author

@fmontesi let's merge.

The parsing issue would need to be addressed in the AST parser? But anyway, this would be a separate patch.

@fmontesi
fmontesi merged commit 6f6e6ca into master Feb 1, 2026
6 checks passed
@fmontesi
fmontesi deleted the fix/init-value branch February 1, 2026 12:01
@Niels-Erik Niels-Erik mentioned this pull request Feb 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmontesi fmontesi Awaiting requested review from fmontesi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mwallnoefer @fmontesi @Niels-Erik
0