8000 Fix/mustache recursive templates by klag · Pull Request #537 · jolie/jolie · GitHub
[go: up one dir, main page]

Skip to content

Fix/mustache recursive templates - #537

Merged
fmontesi merged 2 commits into
masterfrom
fix/mustache-recursive-templates
Nov 13, 2024
Merged

fmontesi merged 2 commits into
masterfrom
fix/mustache-recursive-templates

Conversation

@klag
@klag klag commented Nov 7, 2024
Copy link
Copy Markdown
Member

No description provided.

Comment thread test/library/mustache.ol
}

embed Mustache as mustache
embed Console as Console
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You import and embed console but it's not used. Remove?

Comment thread packages/mustache.ol
data:undefined ///< The data for the template
dir?:string ///< The directory in which to look for other templates (for partials)
recursionLimit?: int ///< Maximum limit for recursive calls in partials. Default is 100
partialsRecursionLimit?: int ///< Maximum limit for recursive calls specific for partials. Dafult is 10
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is exactly the difference between recursionLimit and partialsRecursionLimit? Is there another way to do recursion than using partials?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recursionLimit is the general count of recursive calls. partialsRecursionLimit is the limit in recurisve calls specifically for each partials. In case you have more recursive dependency among partials, you need both for determine the depth of the tree

@fmontesi
fmontesi merged commit 5d19e66 into master Nov 13, 2024
@fmontesi
fmontesi deleted the fix/mustache-recursive-templates branch November 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0