[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick english suggestions of improvement for the readme #543

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Quick english suggestions of improvement for the readme #543

merged 1 commit into from
Oct 29, 2024

Conversation

Nek-
Copy link
Contributor
@Nek- Nek- commented Oct 22, 2024

No description provided.

ternel
ternel reviewed Oct 22, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
lyrixx
lyrixx reviewed Oct 24, 2024
View reviewed changes
Copy link
Member
@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mouais, Not sure it's better. I asked a native speaker and both are valid.

So i'm +0 on this one. Let's wait more feedback

pyrech
pyrech reviewed Oct 29, 2024
View reviewed changes
Copy link
Member
@pyrech pyrech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +0.5 on this, I think I prefer this version but without any strong opinion on which one is better

@lyrixx lyrixx merged commit 0afb34d into jolicode:main Oct 29, 2024
9 checks passed
@lyrixx
Copy link
Member
lyrixx commented Oct 29, 2024

Thanks

@Nek- Nek- deleted the patch-1 branch November 4, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrech pyrech pyrech left review comments

@lyrixx lyrixx lyrixx left review comments

@ternel ternel ternel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nek- @lyrixx @ternel @pyrech