8000 Release edge-26.7.1: fix(destination)!: Disallow requests to undefined service ports (#15473) · jojinkb/linkerd2 · GitHub
[go: up one dir, main page]

Skip to content

edge-26.7.1

@adleong adleong tagged this 16 Jul 18:03
https://github.com/linkerd/linkerd2/pull/14149 fixed https://github.com/linkerd/linkerd2/issues/13922 in the case where no ServiceProfile was defined for the target service.

However, when a ServiceProfile is defined for a service, Linkerd will use the `GetProfile` API instead of the client policy API and requests will be allowed to ports not defined in the service.

Unfortunately, the `GetProfile` API does not have a mechanism to signal that connections should be denied.  Therefore, when we encounter a `GetProfile` request for a port which is not defined on the service, we return an empty `DestinationProfile`. This causes the proxy to fall back to the client policy API which correctly returns a Forbidden filter and causes the connection to be denied.

We also add an integration test for both the ServiceProfile and non-ServiceProfile cases.

Signed-off-by: Alex Leong <alex@buoyant.io>
Assets 2
Loading
0