8000 Count the daily goal in distinct cards, not answers by jmahmood · Pull Request #23 · jmahmood/CardBrick · GitHub
[go: up one dir, main page]

Skip to content

Count the daily goal in distinct cards, not answers - #23

8000
Merged
jmahmood merged 1 commit into
masterfrom
claude/studying-ahead-plan-7cmij2
Jul 7, 2026
Merged

jmahmood merged 1 commit into
masterfrom
claude/studying-ahead-plan-7cmij2

Conversation

@jmahmood
@jmahmood jmahmood commented Jul 7, 2026
Copy link
Copy Markdown
Owner

Follow-up to #20: the daily goal (daily_goal_cards) now counts distinct cards answered today instead of total answers.

What changed

  • A hard card rated Again that cycles through its learning steps consumes the goal once, no matter how many times it comes back — struggling can no longer inflate progress toward "150 cards a day".
  • cards_done (used by the sprint budget in get_due_cards and by sprint_status) is now derived from the existing distinct-card daily_counts; the daily_answer_count query added in Implement sprint-based microstudying with study-ahead fill #20 is deleted.
  • Docstrings, README, CLI help, and the plan doc updated to say "distinct cards".
  • test_goal_counts_distinct_cards_not_answers proves a learning-step repeat leaves room in the goal budget for another due card; test_cards_done_counts_distinct_cards pins the sprint_status side.

Verification

  • Full suite: 157 passed, 1 skipped
  • ruff check cardbrick-py/ clean
  • Headless end-to-end drive of the pygame UI (two goal sprints back-to-back → bonus sprint → all-done screen) still passes with the expected session/card counts

🤖 Generated with Claude Code

https://claude.ai/code/session_01BpqXQKjiwd3ogsmumtDe2j


Generated by Claude Code

@jmahmood
jmahmood merged commit 3e76431 into master Jul 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0