8000 ✅ Fixed sort index issue with typesense indexing by pushrbx · Pull Request #491 · jikan-me/jikan-rest · GitHub
[go: up one dir, main page]

Skip to content

✅ Fixed sort index issue with typesense indexing - #491

Merged
pushrbx merged 8 commits into
masterfrom
typesense-indexing-fix
Feb 1, 2024
Merged

pushrbx merged 8 commits into
masterfrom
typesense-indexing-fix

Conversation

@pushrbx
@pushrbx pushrbx commented Jan 31, 2024
Copy link
Copy Markdown
Collaborator

All models have a "title" field, and that's the default sorting field, however this is not being indexed as such for the models, except where explicitly specified (Anime and Manga models)

Fixes #488

Please note that after this change all of those who are self hosting need to reindex everything in typesense via:

php artisan scout:flush App\\Character
php artisan scount:import App\\Character

Plus the other models: Anime, Manga, Person, Club, Profile, GenreAnime, GenreManga

- all models have a "title" field, and that's the default sorting field, however this is not being indexed as such for the models, except where explicitly specified (Anime and Manga models)
@pushrbx
pushrbx requested a review from a team as a code owner January 31, 2024 18:38
@codecov
codecov Bot commented Jan 31, 2024 •
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02613f5) 56.92% compared to head (f590e29) 57.18%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #491      +/-   ##
============================================
+ Coverage     56.92%   57.18%   +0.26%     
- Complexity     1351     1352       +1     
============================================
  Files           339      339              
  Lines          5444     5454      +10     
============================================
+ Hits           3099     3119      +20     
+ Misses         2345     2335      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pushrbx pushrbx changed the title ✔️ Fixed sort index issue with typesense indexing ✅ Fixed sort index issue with typesense indexing Jan 31, 2024
@irfan-dahir irfan-dahir left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pushrbx
pushrbx merged commit fb50674 into master Feb 1, 2024
@pushrbx
pushrbx deleted the typesense-indexing-fix branch May 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 In the public API's server the characters collection in typesense has the wrong schema

2 participants

0