8000 getHelpfulCount() returns the review's total reactions by irfan-dahir · Pull Request #662 · jikan-me/jikan · GitHub
[go: up one dir, main page]

Skip to content

getHelpfulCount() returns the review's total reactions - #662

Merged
irfan-dahir merged 1 commit into
masterfrom
v5/helpful-count-reactions
Oct 15, 2026
Merged

irfan-dahir merged 1 commit into
masterfrom
v5/helpful-count-reactions

Conversation

@irfan-dahir
Copy link
Copy Markdown
Collaborator

MyAnimeList's 2022 review redesign replaced "helpful" votes with seven reactions (Nice, Love it, Funny, Confusing, Informative, Well-written, Creative). Neither getHelpfulCount() worked:

  • Anime version: a hard-coded return 0; //@todo replace with reactions array, with the old parsing code below it never running.
  • Manga version: still looked for the old vote-count markup and failed when it found none.

Both now return the total reactions MyAnimeList reports for the review (getReactions()->getOverall()). The docblock says what it counts: all reactions, including Funny and Confusing. getReactions() gives the breakdown. This was the owner's decision; deprecating it was the alternative.

Test: ReviewScoresTest checks every recorded anime and manga review. The helpful count equals MyAnimeList's total, the total equals the sum of the seven reactions, and it isn't always 0.

Changelog: under Changed, since the value goes from always-0 to a real count.

🤖 Generated with Claude Code

MyAnimeList's 2022 review redesign replaced "helpful" votes with reactions. The
anime getHelpfulCount() was a hard-coded 0 and the manga one failed looking for
the removed vote markup. Both now return the reactions total MyAnimeList reports
(owner decision
81BA
: total of all reactions), documented as such.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@irfan-dahir
irfan-dahir merged commit 43e1e66 into master Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0