Repository navigation
Add UPGRADING.md: the v4 to v5 guide - #665
Merged
Merged
Conversation
Written from the real difference between v4.0.13 and v5: the public API diff (removed classes and methods, 78 return-type changes) and a side-by-side run of both versions on 85 recorded pages (51 identical; every other difference is in the guide). Linked from the readme. Also corrects the v5.0.0 changelog note that said the public surface "removes nothing": it removes a few classes and methods and makes many getters nullable. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade guide for v4 users, as the RC needs. It's linked from the readme.
How it was checked
It's not written from the changelog alone.
v4.0.13and current master were compared class by class: 4 classes and 6 methods removed, 40 classes added, 78 return types changed.v4.0.13(installed in a scratch directory) and v5 were both run against the same 85 recorded MyAnimeList pages covering the endpoints they share, and the parsed results compared field by field. 51 pages are identical. Every real difference in the other 34 is in the guide (relative dates like "6 minutes ago" move with the clock and are left out).What it covers
Requirements (PHP 8.4.4, the Symfony libraries), the code that has to change, the getters that can now return
null, results that are different, what's new, and a checklist.It also corrected some things I'd have written wrong
Person::getPublishedManga()and manga related entries were broken in the v5 beta, not in v4, so they are not in the guide as "fixes".AnimeParser::getModel()called twice does fail in v4 and works in v5, so that one is listed.typeandairingStartasnull, not wrong values.Depends on
+09:00in v4).Docs only: no code changes.
🤖 Generated with Claude Code