Repository navigation
Align search filter constants with MyAnimeList's search form - #653
Merged
Merged
Conversation
From #636. The search form now offers anime types 7 CM, 8 PV and 9 TV Special, manga type 2 Light Novel / 8 Novel, and manga statuses 4 On Hiatus and 5 Discontinued. SEARCH_MANGA_NOVEL sent 2, which MyAnimeList reads as Light Novel; it is now 8, with SEARCH_MANGA_LIGHT_NOVEL for 2. SearchFormConstantsTest compares each constant group (anime/manga type and status, anime rating) by label and value with the <select> options on the recorded search pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #636: the concrete defect in that issue. The enum and value-object work it plans is not included.
Search requests send
Constants::SEARCH_*values to MyAnimeList unchanged, so a stale constant quietly searches for something else. Checked against the search forms on the recorded search pages, which match the live site (checked today):SEARCH_MANGA_NOVEL = 2, which was actually Light NovelChanges
SEARCH_ANIME_CM,SEARCH_ANIME_PV,SEARCH_ANIME_TV_SPECIALSEARCH_MANGA_LIGHT_NOVELSEARCH_MANGA_STATUS_ON_HIATUS,SEARCH_MANGA_STATUS_DISCONTINUEDSEARCH_MANGA_NOVELgoes from 2 to 8. Callers using it will now get novels instead of light novels, which is what the name always meant. The changelog tells anyone who wants light novels to switch toSEARCH_MANGA_LIGHT_NOVEL.SearchFormConstantsTest. It compares each group with the<select>on the recorded search pages, by label and by value. When the fixtures are re-recorded, it fails if MyAnimeList adds, removes or renumbers an option.The full suite and
composer quality:staticpass.🤖 Generated with Claude Code