8000 RC sweep: user reviews pagination, dead imports, stale todos by irfan-dahir · Pull Request #659 · jikan-me/jikan · GitHub
[go: up one dir, main page]

Skip to content

RC sweep: user reviews pagination, dead imports, stale todos - #659

Merged
irfan-dahir merged 2 commits into
masterfrom
v5/rc-sweep
Oct 15, 2026
Merged

irfan-dahir merged 2 commits into
masterfrom
v5/rc-sweep

Conversation

@irfan-dahir
Copy link
Copy Markdown
Collaborator

Found by an RC-readiness sweep of the repository.

  • User reviews paging never ended. UserReviewsParser::hasNextPage() was hard-coded to true and getLastVisiblePage() to 1, both marked "TODO: Add implementation".
    • What MyAnimeList shows (checked on one live profile with many reviews): 10 reviews per page and a single "More Reviews" link to ?p=N, with no page count.
    • The fix: both methods now follow that link, the same way "recently updated by users" already works.
    • Tests: UserReviewsPaginationTest covers one page, a next-page link, and a link back to an earlier page. There's a changelog entry under Fixed.
  • Dead imports: 8 use lines naming classes that don't exist (LicensorMeta, StudioMeta, and others). None was referenced, so nothing changes at runtime.
  • Stale @todos: removed two "pagination" comments for work that was done in Test suite phase 2: clock, variant corpus, and the parser bugs it found #643.

No src behaviour changes apart from the pagination fix. The security advisory from the sweep (symfony/expression-language, pulled in by GrumPHP) is a dev-only dependency. composer.lock isn't tracked, so CI and fresh installs already get the patched v8.1.9.

🤖 Generated with Claude Code

irfan-dahir and others added 2 commits October 15, 2026 20:35
- UserReviewsParser::hasNextPage() was hard-coded to true and
  getLastVisiblePage() to 1. MyAnimeList shows 10 per page and links only the
  next one ("More Reviews", ?p=N, checked live); both now follow that link.
- Removed 8 `use` lines naming classes that do not exist (never referenced).
- Removed two @todo comments for pagination that was implemented earlier.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The PR's mutation run flagged a no-op max(1, ...) and casts; the next page is now
the lowest linked page after the current one. Tests cover a URL with no ?p= and
links to the current page and several later ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@irfan-dahir
irfan-dahir merged commit 04038c0 into master Oct 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0