8000 chore: tighten grumphp blacklist; resolve API-standard sign-off decisions by irfan-dahir · Pull Request #610 · jikan-me/jikan · GitHub
[go: up one dir, main page]

Skip to content

chore: tighten grumphp blacklist; resolve API-standard sign-off decisions - #610

Merged
irfan-dahir merged 1 commit into
docs/review-fixesfrom
chore/grumphp-blacklist-and-standard-signoff
Oct 11, 2026
Merged

irfan-dahir merged 1 commit into
docs/review-fixesfrom
chore/grumphp-blacklist-and-standard-signoff

Conversation

@irfan-dahir
Copy link
Copy Markdown
Collaborator

Stacked on #609. Implements the three review decisions you picked:

1. grumphp blacklist — tightened to call forms

My earlier 'over-broad' framing was wrong; this is a deliberate style-gate that conforms. The only foot-gun: keywords are passed to git grep --cached -G as POSIX basic regexes OR'd as substrings, so a bare exit/var_dump blocked any changed PHP line that merely mentioned the word in prose (a docblock saying 'exits with exit code N'). Now scoped to the actual statements:

  • var_dump(, die(, ini_set(, error_reporting(, exit(, exit; — every real debug/termination call still caught
  • else kept — jikan is an early-return codebase (zero else in 388 files) and the gate enforces it

Validated with a controlled git grep test: the tightened var_dump( flags the real call but NOT a line that mentions 'var_dump' in prose; same for exit; vs a comment.

2. API-STANDARD.md §7 — resolved

  • Deprecated title accessors (Anime::getTitle*, Manga::getTitle*, Producer::getName) stay not scheduled indefinitely — surface stays a compatibility superset.
  • Standard approved as written — becomes the review benchmark.

3. DECISIONS.md — three new entries

Deprecation/release policy, API-standard approval, and the toolchain-gates decision — all recorded with reasons and impacts.

Committed through the merged pre-commit hook; the tightened blacklist matched nothing in this diff.

…ions

Per maintainer sign-off on the 6-PR review:

- grumphp.yml: git-blacklist keywords scoped to their call forms
  (var_dump(, die(, ini_set(, error_reporting(, exit(, exit;) instead of bare
  words. grumphp passes them to 'git grep --cached -G', so they are POSIX
  basic regexes OR'd as substrings; a bare 'exit'/'var_dump' blocked any
  changed PHP line merely MENTIONING the word in prose (e.g. a docblock
  saying 'exits with exit code N'). The call forms still catch every real
  debug/termination statement, and no current src/ line matches any of them.
  'else' is kept — jikan is an early-return codebase (zero else in src/) and
  the gate enforces that style. Validated with a controlled git grep test:
  the tightened patterns flag the real call, not prose.

- API-STANDARD.md: §7 'Open decisions' -> 'Decisions on this standard
  (resolved 2026-10-11)': deprecated title accessors stay 'not scheduled'
  indefinitely; the standard is approved as written and is the review
  benchmark.

- DECISIONS.md: three new entries (deprecation/release policy, API-standard
  approval, toolchain-gates decision) recording all three calls.

Committed through the merged pre-commit hook; grumphp now runs the tightened
blacklist (matches nothing in this diff).
@irfan-dahir
irfan-dahir merged commit 56f318d into docs/review-fixes Oct 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0