Repository navigation
chore: tighten grumphp blacklist; resolve API-standard sign-off decisions - #610
Merged
irfan-dahir merged 1 commit intoOct 11, 2026
Conversation
…ions Per maintainer sign-off on the 6-PR review: - grumphp.yml: git-blacklist keywords scoped to their call forms (var_dump(, die(, ini_set(, error_reporting(, exit(, exit;) instead of bare words. grumphp passes them to 'git grep --cached -G', so they are POSIX basic regexes OR'd as substrings; a bare 'exit'/'var_dump' blocked any changed PHP line merely MENTIONING the word in prose (e.g. a docblock saying 'exits with exit code N'). The call forms still catch every real debug/termination statement, and no current src/ line matches any of them. 'else' is kept — jikan is an early-return codebase (zero else in src/) and the gate enforces that style. Validated with a controlled git grep test: the tightened patterns flag the real call, not prose. - API-STANDARD.md: §7 'Open decisions' -> 'Decisions on this standard (resolved 2026-10-11)': deprecated title accessors stay 'not scheduled' indefinitely; the standard is approved as written and is the review benchmark. - DECISIONS.md: three new entries (deprecation/release policy, API-standard approval, toolchain-gates decision) recording all three calls. Committed through the merged pre-commit hook; grumphp now runs the tightened blacklist (matches nothing in this diff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #609. Implements the three review decisions you picked:
1. grumphp blacklist — tightened to call forms
My earlier 'over-broad' framing was wrong; this is a deliberate style-gate that conforms. The only foot-gun: keywords are passed to
git grep --cached -Gas POSIX basic regexes OR'd as substrings, so a bareexit/var_dumpblocked any changed PHP line that merely mentioned the word in prose (a docblock saying 'exits with exit code N'). Now scoped to the actual statements:var_dump(,die(,ini_set(,error_reporting(,exit(,exit;— every real debug/termination call still caughtelsekept — jikan is an early-return codebase (zeroelsein 388 files) and the gate enforces itValidated with a controlled
git greptest: the tightenedvar_dump(flags the real call but NOT a line that mentions 'var_dump' in prose; same forexit;vs a comment.2. API-STANDARD.md §7 — resolved
not scheduledindefinitely — surface stays a compatibility superset.3. DECISIONS.md — three new entries
Deprecation/release policy, API-standard approval, and the toolchain-gates decision — all recorded with reasons and impacts.
Committed through the merged pre-commit hook; the tightened blacklist matched nothing in this diff.