8000 Allow using PHP 8.0 with Jikan by rjd22 · Pull Request #370 · jikan-me/jikan · GitHub
[go: up one dir, main page]

Skip to content

Allow using PHP 8.0 with Jikan - #370

Merged
irfan-dahir merged 1 commit into
jikan-me:3.0.0from
nezu-io:3.0.0
Oct 31, 2021
Merged

irfan-dahir merged 1 commit into
jikan-me:3.0.0from
nezu-io:3.0.0

Conversation

@rjd22
@rjd22 rjd22 commented Oct 23, 2021
Copy link
Copy Markdown
Contributor

To be able to develop and test PHP 8.0 it needs to be allowed in the composer.json first

To be able to develop and test PHP 8.0 it needs to be allowed in the composer.json first
@rjd22
rjd22 commented Oct 23, 2021
Copy link
Copy Markdown
Contributor Author

I've been using jikan with PHP 8 for a while and didn't notice any problems. Of any problems come up I will fix those.

@irfan-dahir
irfan-dahir self-requested a review October 25, 2021 17:07
@rjd22
rjd22 commented Oct 30, 2021
Copy link
Copy Markdown
Contributor Author

@irfan-dahir would you have some time to check this change out. It's not that big and allows me to check if more changes are needed for PHP 8.

@irfan-dahir
irfan-dahir merged commit 88f96c5 into jikan-me:3.0.0 Oct 31, 2021
@irfan-dahir
Copy link
Copy Markdown
Collaborator

Thanks for the PR, @rjd22 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0