Repository navigation
Conversation
- Check mm_idx_reader_open return value before dereference and return error if null - Introduce IdxReaderGuard to ensure reader is closed exactly once on all paths - Store None for idx_reader in returned Aligner instead of dereferencing freed pointer - Pass null pointer for output index when None - Add regression tests covering index creation, mapping, cloning/dropping, failed opening, and repeated lifecycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an index-reader ownership issue and null pointer dereference in
lib.rs:set_index:mm_idx_reader_openreturn value before dereferencing; return a Rust error if null.IdxReaderGuard) to ensuremm_idx_reader_closeis called exactly once on all paths.Noneforidx_readerin the returnedAlignerrather than dereferencing and storing a copy of the freed reader struct.outputtomm_idx_reader_openwhenNoneis provided instead of passing an empty string pointer.idx_readerisNoneon clones.