Fix diff highlight of symbol-keyed object. #9499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9499 +/- ##
==========================================
+ Coverage 65.01% 65.03% +0.01%
==========================================
Files 283 283
Lines 12135 12148 +13
Branches 3003 3009 +6
==========================================
+ Hits 7890 7900 +10
- Misses 3604 3606 +2
- Partials 641 642 +1
Continue to review full report at Codecov.
|
pedrottimark
approved these changes
Feb 2, 2020
This was referenced Apr 16, 2020
This was referenced Apr 25, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9432.
Use
Object.getOwnPropertySymbolsto traverse object's symbol key can fix this issue.Thanks @pedrottimark to point out this edge case.
Test plan
Add symbol-keyed object tests.