[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rtorrent request queue memory leak #650

Merged
merged 4 commits into from
Jul 3, 2023
Merged

fix rtorrent request queue memory leak #650

merged 4 commits into from
Jul 3, 2023

Conversation

trim21
Copy link
Collaborator
@trim21 trim21 commented Jun 11, 2023 •
edited
Loading

Description

use p-queue to queue requests

p-queue is a esm only package, so ts-node is replaced with tsx

esbuild-jest is added to transform esm only packages.

Related Issue

close #648

Screenshots

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@trim21
Copy link
Collaborator Author
trim21 commented Jun 11, 2023

emmmmm, looks like jest doesn't work with esm only package

@codecov
Copy link
codecov bot commented Jun 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.95 🎉

Comparison is base (3b8a66c) 72.16% compared to head (47fbe57) 77.11%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #650      +/-   ##
==========================================
+ Coverage   72.16%   77.11%   +4.95%     
==========================================
  Files          61       61              
  Lines       11369    11313      -56     
  Branches     1008     1283     +275     
==========================================
+ Hits         8204     8724     +520     
+ Misses       3149     2575     -574     
+ Partials       16       14       -2
Impacted Files Coverage Δ
server/services/rTorrent/clientRequestManager.ts 100.00% <100.00%> (+7.33%) ⬆️

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trim21
Copy link
Collaborator Author
trim21 commented Jun 17, 2023

@jesec

@jesec jesec merged commit 2b652f8 into jesec:master Jul 3, 2023
@jesec
Copy link
Owner
jesec commented Jul 3, 2023

This is great! Thank you, @trim21 . One thing I am very happy to see is that this simplified the logics a lot. I do have some wild concerns about introducing esbuild world of tools, but we can handle that later.

@trim21 trim21 deleted the fix-rtorrent-mem-leak branch July 3, 2023 22:39
@trim21
Copy link
Collaborator Author
trim21 commented Jul 4, 2023

This is great! Thank you, @trim21 . One thing I am very happy to see is that this simplified the logics a lot. I do have some wild concerns about introducing esbuild world of tools, but we can handle that later.

what concerns do you have? for example, tsx doesn't perform type checking?

@trim21 trim21 restored the fix-rtorrent-mem-leak branch July 13, 2023 12:18
@trim21 trim21 deleted the fix-rtorrent-mem-leak branch December 9, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leak
2 participants
@trim21 @jesec