Repository navigation
feat(agents): graduate native iOS craft routing - #248
Conversation
There was a problem hiding this comment.
Independent code review
Summary: This PR graduates retained native iOS product-language, compact-layout, and evidence-bound review doctrine into selectively routed knowledge, then updates generated designer/curator contracts and regression coverage. The change stays within Issue #247's owned files and leaves capability assurance, profiles, iPadOS doctrine, and Figma-hand scope unchanged.
Risk level: Low. The production change is Markdown instruction routing plus one exact command-allowlist entry; the deterministic CLI behavior is unchanged.
Findings: No Critical, Important, or Suggestion findings.
Verification:
- Remote PR head is
540cf7130432170108907df00ffda48d48c765bd; the GitHub PR diff is byte-identical to the locally reviewed base-to-head diff. - Exact activation checks returned distinct iOS and iPadOS routes, exact sibling-free
selectedKnowledgesets,PROVISIONALassurance, andQUALIFIED_DELIVERY_FORBIDDEN. - Generated designer and curator instructions preserve maker/judge separation and receipt-bound selective loading; the unchanged Figma hand has no native-craft preload.
- Focused plan suite passed: 8 files, 92 tests, 0 failures. Diff hygiene passed.
- All 12 held-out manifest hashes matched their prompts, raw responses, evidence inputs, and generated-agent files.
- At review time, recall, accessibility, and design-os CI jobs passed; the main check job remained in progress.
Verdict: Approve. No code-review blocker remains; merge still depends on required CI completing successfully.
Posted by the installed review-pr skill at 2026-08-30T01:54:17Z
Summary
Verification
Boundaries
This improves task-routed agent knowledge. It does not change native arm qualification, assurance claims, capability profiles, or Figma-hand scope.
Closes #247