8000 chore: move token classes into chat templates by jaideepr97 · Pull Request #324 · instructlab/training · GitHub
[go: up one dir, main page]

Skip to content

chore: move token classes into chat templates - #324

Merged
JamesKunstle merged 1 commit into
instructlab:mainfrom
jaideepr97:move-tokens
Nov 8, 2024
Merged

JamesKunstle merged 1 commit into
instructlab:mainfrom
jaideepr97:move-tokens

Conversation

@jaideepr97
Copy link
Copy Markdown
Contributor

moves base classes used in the chat templates out of tokenizer_utils.py so that chat templates can be easily imported without pulling in unnecessary imports from other parts of the code

@mergify
mergify Bot commented Nov 7, 2024
Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. @jaideepr97 please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Signed-off-by: Jaideep Rao <jrao@redhat.com>
@mergify mergify Bot added the one-approval label Nov 8, 2024
@mergify mergify Bot removed the one-approval label Nov 8, 2024
@JamesKunstle JamesKunstle left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@JamesKunstle
JamesKunstle merged commit 45162d5 into instructlab:main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0