8000 fix: Add explicit flash_attn requirement for ROCm by fabiendupont · Pull Request #255 · instructlab/training · GitHub
[go: up one dir, main page]

Skip to content

fix: Add explicit flash_attn requirement for ROCm - #255

Merged
mergify[bot] merged 1 commit into
instructlab:mainfrom
fabiendupont:rhelai-1729
Oct 7, 2024
Merged

mergify[bot] merged 1 commit into
instructlab:mainfrom
fabiendupont:rhelai-1729

Conversation

@fabiendupont
Copy link
Copy Markdown
Contributor

No description provided.

@mergify mergify Bot added the dependencies Pull requests that update a dependency file label Oct 7, 2024
Signed-off-by: Fabien Dupont <fdupont@redhat.com>
@nathan-weinberg nathan-weinberg changed the title RHELAI-1729: Add explicit flash_attn requirement for ROCm Add explicit flash_attn requirement for ROCm Oct 7, 2024
@fabiendupont fabiendupont changed the title Add explicit flash_attn requirement for ROCm fix: Add explicit flash_attn requirement for ROCm Oct 7, 2024
@Maxusmusti Maxusmusti left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maxusmusti Maxusmusti removed the hold label Oct 7, 2024
@mergify mergify Bot added the one-approval label Oct 7, 2024
@mergify
mergify Bot merged commit 8579069 into instructlab:main Oct 7, 2024
@mergify mergify Bot removed the one-approval label Oct 7, 2024
@Maxusmusti
Copy link
Copy Markdown
Collaborator

@Mergifyio backport release-v0.5

@mergify
mergify Bot commented Oct 8, 2024 •
Copy link
Copy Markdown
Contributor

backport release-v0.5

✅ Backports have been created

Details

mergify Bot added a commit that referenced this pull request Oct 8, 2024
fix: Add explicit flash_attn requirement for ROCm (backport #255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0