Repository navigation
chore: add exit code & tox fix - #217
Merged
Merged
Conversation
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Contributor
|
@RobotSail Is this still useful after #229? |
Member
Author
|
@JamesKunstle They are similar but this is specifically when an error occurs within the child process. The other PR seems to only be covering the case when a |
nathan-weinberg
approved these changes
Oct 16, 2024
RobotSail
force-pushed
the
propogate-failure
branch
from
October 16, 2024 18:09
2951e46 to
ae60ce0
Compare
RobotSail
force-pushed
the
propogate-failure
branch
2 times, most recently
from
October 16, 2024 18:13
9d6a3e2 to
6c2d97a
Compare
danmcp
reviewed
Oct 16, 2024
RobotSail
force-pushed
the
propogate-failure
branch
from
October 16, 2024 20:40
6c2d97a to
832afc7
Compare
RobotSail
force-pushed
the
propogate-failure
branch
from
October 16, 2024 21:06
832afc7 to
e034b8c
Compare
RobotSail
force-pushed
the
propogate-failure
branch
from
October 16, 2024 21:25
e034b8c to
13a1373
Compare
Currently, the training library does not exit when an error is encountered within the training loop (invoked through torchrun). This commit updates that functionality so we correctly return an exit code of 1 on child failure. Additionally, this commit also adds the `make fix` command which automatically fixes all trivial issues picked up on by ruff Signed-off-by: Oleg S <97077423+RobotSail@users.noreply.github.com>
RobotSail
force-pushed
the
propogate-failure
branch
from
October 16, 2024 21:35
13a1373 to
9c899dc
Compare
danmcp
approved these changes
Oct 17, 2024
Contributor
There was a problem hiding this comment.
Note: There might be some changes necessary in the CLI after this change to handle the exception and exit with an appropriate message.
Collaborator
|
@Mergifyio backport release-v0.5 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
added a commit
that referenced
this pull request
Oct 21, 2024
chore: add exit code & tox fix (backport #217)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the training library does not exit when an error is encountered
within the training loop (invoked through torchrun). This commit updates
that functionality so we correctly return an exit code of 1 on child failure.
Additionally, this commit also adds the
make fixcommand whichautomatically fixes all trivial issues picked up on by ruff
Signed-off-by: Oleg S 97077423+RobotSail@users.noreply.github.com
Resolves #216