Repository navigation
Add flag for disabling flash attention - #15
Closed
Maxusmusti wants to merge 1 commit into
Closed
Maxusmusti wants to merge 1 commit into
Maxusmusti wants to merge 1 commit into
Conversation
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
Maxusmusti
force-pushed
the
flash-attn-toggle
branch
from
June 13, 2024 19:03
a33992e to
c92dedc
Compare
Contributor
|
are we sure that not specifying the attention mechanism is enough for this not to fail?. We need to setup the 3090 machine from Mo, I guess we can spinup docker containers there just to not mess up with her drivers? |
fabianlim
reviewed
Jun 17, 2024
| attn_implementation="flash_attention_2", | ||
| torch_dtype=torch.bfloat16, | ||
| **base_model_args, | ||
| use_padding_free_transformer=True, |
Contributor
There was a problem hiding this comment.
if you want to disable FA2, you also need to disable padding free, since it uses FA2 under the hood
8000
RobotSail
reviewed
Jun 18, 2024
Member
There was a problem hiding this comment.
Will need to test this but otherwise it looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For hardware scenarios where flash attention is potentially not supported.