You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
When inklecate crashes, we should handle it specially #2
I'm looking into adding a floating ExceptionView that shows exceptions in the bottom right corner of the editor (as floating boxes that can be closed).
It similar to the atom error boxes but would be cool to extend them with actions (e.g. email details, etc)
What do you think? Floating boxes may not be trivial to implement though, would you be ok using a jquery plugin for this? I'm researching how to avoid that though.
To be honest I don't think there's any need to build any specialised UI for
this. Inklecate crashing is supposed to be very rare, and should be
getting more rare all the time! :)
So I'd just present it basically like a runtime error: just some red text
that gets appended to the player view. I definitely wouldn't make it float
or anything - I just don't think there's any reason to add any complexity
there.
It should be really rather simple! Any kind of complexity here just adds
unnecessary bloat to the code base...
I'm looking into adding a floating ExceptionView that shows exceptions in
the bottom right corner of the editor (as floating boxes that can be
closed).
It similar to the atom error boxes but would be cool to extend them with
actions (e.g. email details, etc)
What do you think? Floating boxes may not be trivial to implement though,
would you be ok using a jquery plugin for this? I'm researching how to
avoid that though.
Possible improvement to this: Given that there's quite a lot of text involved in the stack trace, perhaps we could split it up into its newlines and print it slightly more prettily? All the lines are running together due to being HTML! And perhaps use a smallish fixed width font (e.g. using <pre></pre> tags) so it fits better?
Activity
DiogoNeves commentedon May 29, 2016
I'm looking into adding a floating ExceptionView that shows exceptions in the bottom right corner of the editor (as floating boxes that can be closed).
It similar to the atom error boxes but would be cool to extend them with actions (e.g. email details, etc)
What do you think? Floating boxes may not be trivial to implement though, would you be ok using a jquery plugin for this? I'm researching how to avoid that though.
joethephish commentedon May 29, 2016
To be honest I don't think there's any need to build any specialised UI for
this. Inklecate crashing is supposed to be very rare, and should be
getting more rare all the time! :)
So I'd just present it basically like a runtime error: just some red text
that gets appended to the player view. I definitely wouldn't make it float
or anything - I just don't think there's any reason to add any complexity
there.
It should be really rather simple! Any kind of complexity here just adds
unnecessary bloat to the code base...
Does that make sense?
On Sun, 29 May 2016 at 17:13, Diogo Neves notifications@github.com wrote:
DiogoNeves commentedon May 29, 2016
cool, in that case, I should have something ready soon 😄
EDIT: yes, good call there. I agree with you 100%
joethephish commentedon May 29, 2016
Possible improvement to this: Given that there's quite a lot of text involved in the stack trace, perhaps we could split it up into its newlines and print it slightly more prettily? All the lines are running together due to being HTML! And perhaps use a smallish fixed width font (e.g. using
<pre></pre>tags) so it fits better?DiogoNeves commentedon May 29, 2016
sounds good 👍 will do next currently looking at only updating the files that actually changed (possibly a single line change 😉 )
DiogoNeves commentedon May 29, 2016
this is how it looks now
joethephish commentedon May 30, 2016
Thanks, looks good! :)
Merge pull request #141 from bjennings76/master
Merge pull request #2 from inkle/GreenCloversGames-master
Merge pull request #2 from smwhr/with-workflow