Repository navigation
Conversation
dman-os
force-pushed
the
feat/observer-sketch
branch
2 times, most recently
from
May 29, 2026 13:58
ff4e9e0 to
53ff986
Compare
dman-os
force-pushed
the
feat/observer-sketch
branch
from
July 1, 2026 01:42
4de6e00 to
ad90a6f
Compare
dman-os
force-pushed
the
feat/observer-sketch
branch
2 times, most recently
from
July 27, 2026 17:28
c38fdac to
15bec90
Compare
dman-os
commented
Jul 27, 2026
| let hash = hash_event_bytes(&bytes); | ||
|
|
||
| // Quick type detection | ||
| let kind = bincode_deserialize::<StaticEvent<Vec<u8>>>(&bytes) |
| let conns = { | ||
| let subscriber_conns = self.get_authorized_subscriber_conns(id, &self_id).await; | ||
| if subscriber_conns.is_empty() { | ||
| tracing::debug!(tree = ?id, "no subscribers for sedimentree, broadcasting to all connections"); |
Author
There was a problem hiding this comment.
Highlight bug: disabled this strange behavior.
| peer = %peer, | ||
| "sync check passed, peers are in sync" | ||
| ); | ||
| let confirmation = Message::SyncConfirmation { |
Author
There was a problem hiding this comment.
Highlight: we now do acks at the end of the sync round. Not happy about this extra wire message but this buys us the ability to do a deterministically synchronous sync_keyhive. Maybe there's a good timeout based scheme out there though.
| request_id.clone(), | ||
| OutboundRequest { | ||
| peer: target_id.clone(), | ||
| advertised_events, |
Author
There was a problem hiding this comment.
Highlight: we hold onto advertised events for a single sync session/request lest concurrent changes break the visiblity of events to peer. I.e. the peer might request hashes it no longer has access too.
This is a basic solution and has memory costs, more protocol level support for changes across rounds might be appropriate.
dman-os
force-pushed
the
feat/observer-sketch
branch
2 times, most recently
from
August 10, 2026 03:45
9b2422d to
b2d05c6
Compare
4 of 20 tasks
refactor: expose fragment_state_store used during ingest fix: appease clippy fix: bad conditional
dman-os
force-pushed
the
feat/observer-sketch
branch
from
August 14, 2026 06:49
121fc25 to
afd4c49
Compare
- KeyhiveStorage::save_event_with_source (default ignores source); storage_ops thread an optional source peer through save_event/save_event_bytes. - KeyhiveProtocol::with_change_reporter: post-ingestion hook invoked with the hashes of newly inserted events and the peer they were learned from. - KeyhiveProtocol::notification_targets: classify a batch of changed hashes against the connected peer set using the published cache snapshot; returns selected peers + unclassified (pending/lagged) hashes. - Fix pre-existing serde test-harness drift (Arc<Mutex<Keyhive>> -> Arc<Keyhive>, missing request_id fields) so the serde test build compiles; 8 stale protocol tests remain failing (pre-existing, unrelated to this change).
dman-os
force-pushed
the
feat/observer-sketch
branch
from
August 14, 2026 07:03
afd4c49 to
c16da98
Compare
dman-os
force-pushed
the
feat/observer-sketch
branch
from
August 26, 2026 08:39
ce7e5ec to
f27daeb
Compare
dman-os
force-pushed
the
feat/observer-sketch
branch
from
September 7, 2026 06:41
152848d to
35545a2
Compare
…ent cache when nested store generations move; select unattributable peers conservatively
…it, batch, and bulk local writes
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows the bits and bobs I had to change when integrating subduction into my project.
feat(subduction_core): SyncSession: allows observation of single sync exchange with a peer. Allows downstream sedimentree observers to incrementally maintain derived state like Automerge docs as changes come in.refactor(subduction_keyhive)!: sync check hacks: sendsSyncConfirmationmsgs even after recieved sync checks require no work. Acks allow the other side to synchronously wait on keyhive sync tasks instead of them happening in the background.feat(subduction_keyhive): SyncStatus: done signal fromhandle_messageifSyncConfirmationis recieved.related to inkandswitch/keyhive#210