8000 zdxsv: drop the sync fingerprint by inada-s · Pull Request #813 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv: drop the sync fingerprint - #813

Open
inada-s wants to merge 1 commit into
zdxsv-masterfrom
ai/drop-sync-fingerprint
Open

inada-s wants to merge 1 commit into
zdxsv-masterfrom
ai/drop-sync-fingerprint

Conversation

@inada-s
@inada-s inada-s commented Nov 21, 2026
Copy link
Copy Markdown
Owner

Description of Changes

The sync fingerprint is removed. The client no longer computes it, sends it in the platform info (sync=), reads users[].sync from the battle info, or cuts a lobby battle over it. The sync-safe settings are still forced as before.

Test switches: ZDXSV_SYNC_SALT and ZDXSV_DROP_SYNC are gone. The "cut player refuses GGPO" rig now gets its one-sided cut from ZDXSV_LOBBY_CUT=1 (m4z.py LOBBY_CUT=K). The docs and the report fixture no longer list the fingerprint or the sync and sync_differ report fields.

Rationale behind Changes

The lobby only matched players with equal fingerprints, and the fingerprint held the build. With players on two releases, a lobby had full teams but no battle started. Releases are tested for sync with the previous one, and a release that does not sync raises the lobby's min_pcsx2_version. The lobby side is in the zdxsv repository (lobby: start battles regardless of the players' sync fingerprints).

Rollout: 1.1.2 and older clients cut a battle in which a player's sync is missing. When this ships, raise min_pcsx2_version to its release.

Suggested Testing Steps

Run: Devel build; lobbytest.py (0 failed).
Not run: the m4z.py rigs (LOBBY_CUT=3 cut refusal, a lobby battle between two builds).

Did you use AI to help find, test, or implement this issue or feature?

Yes. Claude Code made the change.

🤖 Generated with Claude Code

…by build or settings

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0