Repository navigation
Conversation
…by build or settings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The sync fingerprint is removed. The client no longer computes it, sends it in the platform info (
sync=), readsusers[].syncfrom the battle info, or cuts a lobby battle over it. The sync-safe settings are still forced as before.Test switches:
ZDXSV_SYNC_SALTandZDXSV_DROP_SYNCare gone. The "cut player refuses GGPO" rig now gets its one-sided cut fromZDXSV_LOBBY_CUT=1(m4z.py LOBBY_CUT=K). The docs and the report fixture no longer list the fingerprint or thesyncandsync_differreport fields.Rationale behind Changes
The lobby only matched players with equal fingerprints, and the fingerprint held the build. With players on two releases, a lobby had full teams but no battle started. Releases are tested for sync with the previous one, and a release that does not sync raises the lobby's
min_pcsx2_version. The lobby side is in the zdxsv repository (lobby: start battles regardless of the players' sync fingerprints).Rollout: 1.1.2 and older clients cut a battle in which a player's
syncis missing. When this ships, raisemin_pcsx2_versionto its release.Suggested Testing Steps
Run: Devel build;
lobbytest.py(0 failed).Not run: the
m4z.pyrigs (LOBBY_CUT=3cut refusal, a lobby battle between two builds).Did you use AI to help find, test, or implement this issue or feature?
Yes. Claude Code made the change.
🤖 Generated with Claude Code