8000 Updater test switch: install after the change list loaded or failed by inada-s-ai[bot] · Pull Request #807 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

Updater test switch: install after the change list loaded or failed - #807

Merged
inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/update-install-after-changes
Nov 21, 2026
Merged

inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/update-install-after-changes

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 21, 2026
Copy link
Copy Markdown

Description of Changes

ZDXSV_UPDATE_INSTALL=1 (Devel test switch) now presses Download and Install once the update dialog's change list has loaded or failed, not right after the dialog opens. updateinstall.py no longer stops on a change-list error and no longer needs --offer to be a real GitHub tag.

Rationale behind Changes

The change list comes from the GitHub API (unauthenticated, rate limited). Pressed early, the install had already set the dialog to show errors, so a 403/404 change list opened a modal error box and the install stalled: the rig failed whenever the API rate limit was hit.

Suggested Testing Steps

  • Verified on macOS arm64 (Devel, local zdxsv-0.0.1 tag): updateinstall.py --offer zdxsv-99.0.0 (change list 404) PASS; same with the switch at its old place FAIL (stalls at the modal); --offer zdxsv-0.0.0 control FAIL as expected.
  • Not run: Windows (switch is shared code; updater path there unchanged), CI.

Did you use AI to help find, test, or implement this issue or feature?

Yes: written and tested by an AI agent (Claude).

🤖 Generated with Claude Code

@inada-s-ai
inada-s-ai Bot enabled auto-merge November 21, 2026 14:40
@inada-s-ai
inada-s-ai Bot merged commit 4a65213 into zdxsv-master Nov 21, 2026
4 checks passed
@inada-s-ai
inada-s-ai Bot deleted the ai/update-install-after-changes branch November 21, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0