Repository navigation
Updater test switch: install after the change list loaded or failed - #807
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ZDXSV_UPDATE_INSTALL=1(Devel test switch) now presses Download and Install once the update dialog's change list has loaded or failed, not right after the dialog opens.updateinstall.pyno longer stops on a change-list error and no longer needs--offerto be a real GitHub tag.Rationale behind Changes
The change list comes from the GitHub API (unauthenticated, rate limited). Pressed early, the install had already set the dialog to show errors, so a 403/404 change list opened a modal error box and the install stalled: the rig failed whenever the API rate limit was hit.
Suggested Testing Steps
zdxsv-0.0.1tag):updateinstall.py --offer zdxsv-99.0.0(change list 404) PASS; same with the switch at its old place FAIL (stalls at the modal);--offer zdxsv-0.0.0control FAIL as expected.Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by an AI agent (Claude).
🤖 Generated with Claude Code