8000 zdxsv release: universal macOS app with auto-update asset by inada-s-ai[bot] · Pull Request #805 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv release: universal macOS app with auto-update asset - #805

Open
inada-s-ai[bot] wants to merge 16 commits into
zdxsv-masterfrom
ai/macos-release-prep
Open

inada-s-ai[bot] wants to merge 16 commits into
zdxsv-masterfrom
ai/macos-release-prep

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 21, 2026 •
Copy link
Copy Markdown

Description of Changes

  • zdxsv_release.yml: builds macOS arm64 and x86_64 (production server flags, as Windows), merges them into one universal PCSX2-<tag>.app, signs it ad-hoc and publishes pcsx2-zdxsv-macos.tar.xz (the asset name the macOS updater already looks for). The release job also checks both slices for the server values and adds the file to SHA256SUMS.txt.
  • macos_build.yml: inputs cmakeFlags, zdxsvAppArtifact (builds with -g, keeps the ThinLTO objects, runs dsymutil and uploads the unpacked app + PCSX2.dSYM as a tar; off by default) and universalDeps (the x86_64 release build links the universal deps from the arm64 deps cache, so a release does not build x86_64-only deps).
  • build-dependencies-universal.sh: RapidYAML and Sentry Native now built universal like the other deps (they were arm64-only, so an x86_64 build could not link them).
  • .github/workflows/scripts/zdxsv/macos-universal-app.sh: lipo-merges every arm64-only Mach-O with its x86_64 counterpart, fails on a missing one, codesign --force --deep -s - + --verify --strict.
  • ZDXSV.md / ZDXSV.ja.md: macOS install ("Open Anyway" once), data folder, old app to Trash on update. docs/zdxsv/tools.md: the macOS asset.

Rationale behind Changes

macOS release with auto-update (#802). No Apple Developer Program, so ad-hoc only. Universal is the proposed architecture (one asset, native on both, no updater change); the choice is still open with the owner, hence draft.

Suggested Testing Steps

  • Verified on macos-mini (private rig): the updater installs an update on the x86_64 slice under Rosetta (updateinstall.py, PASS; older offer: FAIL as it must). The script merged the local arm64 and x86_64 Devel bundles (42 files); the universal app boots the game natively (Apple M2) and under Rosetta (Apple M2 (Rosetta)); after tar -cJf and unpack with /usr/bin/tar the signature verifies.
  • CI dry run of the macOS part (branch push, no release): green with the deps fixed above; the universal app has 44 Mach-O files, all x86_64 arm64, bundle ID check passed, dSYM UUIDs equal both slices. That run's x86_64 dSYM had line info for only 4% of sampled functions (arm64: 92%): the later unittests link overwrote the ThinLTO objects. Reproduced on macos-mini (same binary: 386/400 before that link, 19/400 after); fixed by running dsymutil right after Build PCSX2, and the step now fails on could not find symbol (passes on the good log, fails on the bad one). Dry run with this fix: green, x86_64 dSYM line info 392/406 sampled functions. Release job itself (tag push): not run.
  • Crash report symbols: one dSYM per architecture, uploaded with --type dsym (sentry-cli 2.58.6 has no macho type). docs/zdxsv/crash-reports.md: macOS crashes are reported with the fault signal (no abort; checked on macos-mini by signalling a running Sentry-enabled build). Verified on macos-mini: x86_64 Release (ThinLTO) with -g + -object_path_lto gives a dSYM with line info; without -object_path_lto dsymutil reports no debug symbols (the pack step fails on that); the replayed pack + merge steps give dSYM UUIDs equal to both slices, debug-files check: symtab, debug, unwind, usable; a crash of a Sentry-enabled arm64 build against a local DSN (crashrep.py) sends a minidump whose PCSX2 module id equals the dSYM debug ID. The upload to Sentry itself not run.

Did you use AI to help find, test, or implement this issue or feature?

Yes: written and tested by an AI agent (Claude Code).

🤖 Generated with Claude Code

@inada-s-ai
inada-s-ai Bot marked this pull request as ready for review November 21, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0