Repository navigation
zdxsv release: universal macOS app with auto-update asset - #805
Open
inada-s-ai[bot] wants to merge 16 commits into
Open
inada-s-ai[bot] wants to merge 16 commits into
inada-s-ai[bot] wants to merge 16 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… pcsx2-zdxsv-macos.tar.xz
…ey the deps cache)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…csx2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…_64 ThinLTO objects Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
zdxsv_release.yml: builds macOS arm64 and x86_64 (production server flags, as Windows), merges them into one universalPCSX2-<tag>.app, signs it ad-hoc and publishespcsx2-zdxsv-macos.tar.xz(the asset name the macOS updater already looks for). The release job also checks both slices for the server values and adds the file toSHA256SUMS.txt.macos_build.yml: inputscmakeFlags,zdxsvAppArtifact(builds with-g, keeps the ThinLTO objects, runsdsymutiland uploads the unpacked app +PCSX2.dSYMas a tar; off by default) anduniversalDeps(the x86_64 release build links the universal deps from the arm64 deps cache, so a release does not build x86_64-only deps).build-dependencies-universal.sh: RapidYAML and Sentry Native now built universal like the other deps (they were arm64-only, so an x86_64 build could not link them)..github/workflows/scripts/zdxsv/macos-universal-app.sh: lipo-merges every arm64-only Mach-O with its x86_64 counterpart, fails on a missing one,codesign --force --deep -s -+--verify --strict.ZDXSV.md/ZDXSV.ja.md: macOS install ("Open Anyway" once), data folder, old app to Trash on update.docs/zdxsv/tools.md: the macOS asset.Rationale behind Changes
macOS release with auto-update (#802). No Apple Developer Program, so ad-hoc only. Universal is the proposed architecture (one asset, native on both, no updater change); the choice is still open with the owner, hence draft.
Suggested Testing Steps
updateinstall.py, PASS; older offer: FAIL as it must). The script merged the local arm64 and x86_64 Devel bundles (42 files); the universal app boots the game natively (Apple M2) and under Rosetta (Apple M2 (Rosetta)); aftertar -cJfand unpack with/usr/bin/tarthe signature verifies.x86_64 arm64, bundle ID check passed, dSYM UUIDs equal both slices. That run's x86_64 dSYM had line info for only 4% of sampled functions (arm64: 92%): the laterunittestslink overwrote the ThinLTO objects. Reproduced on macos-mini (same binary: 386/400 before that link, 19/400 after); fixed by runningdsymutilright afterBuild PCSX2, and the step now fails oncould not find symbol(passes on the good log, fails on the bad one). Dry run with this fix: green, x86_64 dSYM line info 392/406 sampled functions. Release job itself (tag push): not run.--type dsym(sentry-cli 2.58.6 has nomachotype).docs/zdxsv/crash-reports.md: macOS crashes are reported with the fault signal (no abort; checked on macos-mini by signalling a running Sentry-enabled build). Verified on macos-mini: x86_64 Release (ThinLTO) with-g+-object_path_ltogives a dSYM with line info; without-object_path_ltodsymutil reportsno debug symbols(the pack step fails on that); the replayed pack + merge steps give dSYM UUIDs equal to both slices,debug-files check: symtab, debug, unwind, usable; a crash of a Sentry-enabled arm64 build against a local DSN (crashrep.py) sends a minidump whose PCSX2 module id equals the dSYM debug ID. The upload to Sentry itself not run.Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by an AI agent (Claude Code).
🤖 Generated with Claude Code