8000 zdxsv replay live: the four-screen sync and the auto-next state in two structs by inada-s-ai[bot] · Pull Request #717 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv replay live: the four-screen sync and the auto-next state in two structs - #717

Merged
inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/replay-live-structs
Nov 19, 2026
Merged

inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/replay-live-structs

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 19, 2026
Copy link
Copy Markdown

Description of Changes

ReplayLive.cpp: the four-screen sync thread state (s_sync_thread, _quit, _seek_gen, _pids) becomes ReplaySync s_sync; the live auto-next state (s_live_seen, s_live_next_left, s_live_skips, s_live_next_url) becomes LiveNextState s_live_next (GgpoShared.h, as s_live_next_url was shared). No behavior change.

Rationale behind Changes

AGENTS.md: variables that together have one role are one struct.

Suggested Testing Steps

Verified on windows-mini (private rig, Devel, 15fe2b5 + this change): FOUR=1 CLAMP=none rplay.py PASS (four-screen sync); livenext.py PASS (skip counted, waiting). The BATTLES=2 LIVE=2 LIVE_NEXT=1 m4z.py result follows in a comment. Not run: macOS/Linux builds (CI).

Did you use AI to help find, test, or implement this issue or feature?

Yes: written and tested by an AI agent (Claude Code).

🤖 Generated with Claude Code

@inada-s-ai
inada-s-ai Bot commented Nov 19, 2026
Copy link
Copy Markdown
Author

Private rig (windows-mini, Devel cddfd4d): BATTLES=2 LIVE=2 LIVE_NEXT=1 PWTRACE=1 CLIENTS="1 3" EMU=1 GGPO=7101 GDELAY=auto m4z.py: the spectator watched 2 different live battles, state hashes none differ, pwcheck PASS for both battles. One FAIL, desync checks: the false report that PR 704 fixes, not this change.

@inada-s-ai
inada-s-ai Bot merged commit 465a19b into zdxsv-master Nov 19, 2026
4 checks passed
@inada-s-ai
inada-s-ai Bot deleted the ai/replay-live-structs branch November 19, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0