8000 zdxsv replay play: the control bar and the key display state in two structs by inada-s-ai[bot] · Pull Request #710 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv replay play: the control bar and the key display state in two structs - #710

Merged
inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/replay-bar-struct
Nov 19, 2026
Merged

inada-s-ai[bot] merged 1 commit into
zdxsv-masterfrom
ai/replay-bar-struct

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 19, 2026
Copy link
Copy Markdown

Description of Changes

ReplayPlay.cpp: the 10 control bar atomics (s_bar_*) become ReplayBar s_bar, the key display's mutex, runs and end frame/position (s_keys*) become KeyDisplay s_keys. s_keys_on (a setting, shared through GgpoShared.h) stays. Rename only; no behavior change.

Rationale behind Changes

AGENTS.md: variables that together have one role are one struct.

Suggested Testing Steps

  • Run (windows-mini, Devel, 662b862 + this change; private rig): rplay.py with WINDOW=1 KEYS="15:bar:show,w600,bar:timeline:0.7,shot:..." PASS; the screenshot shows the control bar (frame, round, timeline) and the key display.
  • Not run: Release build, macOS/Linux/arm64 builds (CI).

Did you use AI to help find, test, or implement this issue or feature?

Yes: written and tested by an AI agent (Claude Code).

🤖 Generated with Claude Code

…tructs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai
inada-s-ai Bot enabled auto-merge November 19, 2026 19:27
@inada-s-ai
inada-s-ai Bot merged commit 62c6672 into zdxsv-master Nov 19, 2026
4 checks passed
@inada-s-ai
inada-s-ai Bot deleted the ai/replay-bar-struct branch November 19, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants

0