Repository navigation
zdxsv replay play: the control bar and the key display state in two structs - #710
Merged
Merged
Conversation
…tructs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ReplayPlay.cpp: the 10 control bar atomics (s_bar_*) becomeReplayBar s_bar, the key display's mutex, runs and end frame/position (s_keys*) becomeKeyDisplay s_keys.s_keys_on(a setting, shared throughGgpoShared.h) stays. Rename only; no behavior change.Rationale behind Changes
AGENTS.md: variables that together have one role are one struct.
Suggested Testing Steps
rplay.pywithWINDOW=1 KEYS="15:bar:show,w600,bar:timeline:0.7,shot:..."PASS; the screenshot shows the control bar (frame, round, timeline) and the key display.Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by an AI agent (Claude Code).
🤖 Generated with Claude Code