Repository navigation
zdxsv Settings: Sign Out Everywhere (revoke the tokens of every PC) - #700
Merged
Merged
Conversation
… the Discord account Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
CI fix handover (CMake Clang red)
Status: waiting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Settings → zdxsv → Account gets a Sign Out Everywhere button (after a Yes/No confirmation):
POST /auth/revokewithall=1, which revokes every token of the signed-in Discord account (every PC, this one included), then deletes this PC's token file. If the server does not confirm the revoke, the token file stays so the player can retry, and the status line says "Not signed out; ". The plain Sign Out is unchanged.ZDXSV_AUTH_SIGNIN_TEST=signoutalltriggers it for the rigs. Player docs (en/ja), ja-JP strings,docs/zdxsv/options.mdandtests/zdxsv/README.mdupdated.Needs the server side from inada-s/zdxsv#313 (still open). Against a server without it,
all=1is ignored and only this PC's token is revoked.Rationale behind Changes
Requested in #662 (comment): a way to sign out of every device.
Suggested Testing Steps
tests/zdxsv/signin.py(extended): sign-in, then plain sign-out with a second token of the same user in the db (only this PC's token goes), thensignoutall(all of the user's tokens go). Run on windows-mini: PASS with the server built from zdxsv PR 313; control FAIL with the server built from zdxsvmaster(1 token left aftersignoutall). Also PASS on the local merge with PR 662 (C++ merges cleanly; the ZDXSV.md/ZDXSV.ja.md/README lines conflict, whichever merges second resolves them). One-off check (not committed): unreachable server → token file kept,sign-out on every PC failedlogged.Not run: clicking the button in the Settings UI by hand (the confirmation dialog and status texts are not exercised by the rig), ja-JP strings on screen, macOS/Linux.
Did you use AI to help find, test, or implement this issue or feature?
Yes: written and tested by Claude Code.
🤖 Generated with Claude Code