8000 zdxsv Settings: Sign Out Everywhere (revoke the tokens of every PC) by inada-s-ai[bot] · Pull Request #700 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv Settings: Sign Out Everywhere (revoke the tokens of every PC) - #700

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/zdxsv-signout-all
Nov 19, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/zdxsv-signout-all

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 19, 2026
Copy link
Copy Markdown

Description of Changes

Settings → zdxsv → Account gets a Sign Out Everywhere button (after a Yes/No confirmation): POST /auth/revoke with all=1, which revokes every token of the signed-in Discord account (every PC, this one included), then deletes this PC's token file. If the server does not confirm the revoke, the token file stays so the player can retry, and the status line says "Not signed out; ". The plain Sign Out is unchanged. ZDXSV_AUTH_SIGNIN_TEST=signoutall triggers it for the rigs. Player docs (en/ja), ja-JP strings, docs/zdxsv/options.md and tests/zdxsv/README.md updated.

Needs the server side from inada-s/zdxsv#313 (still open). Against a server without it, all=1 is ignored and only this PC's token is revoked.

Rationale behind Changes

Requested in #662 (comment): a way to sign out of every device.

Suggested Testing Steps

tests/zdxsv/signin.py (extended): sign-in, then plain sign-out with a second token of the same user in the db (only this PC's token goes), then signoutall (all of the user's tokens go). Run on windows-mini: PASS with the server built from zdxsv PR 313; control FAIL with the server built from zdxsv master (1 token left after signoutall). Also PASS on the local merge with PR 662 (C++ merges cleanly; the ZDXSV.md/ZDXSV.ja.md/README lines conflict, whichever merges second resolves them). One-off check (not committed): unreachable server → token file kept, sign-out on every PC failed logged.
Not run: clicking the button in the Settings UI by hand (the confirmation dialog and status texts are not exercised by the rig), ja-JP strings on screen, macOS/Linux.

Did you use AI to help find, test, or implement this issue or feature?

Yes: written and tested by Claude Code.

🤖 Generated with Claude Code

… the Discord account

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@inada-s-ai
inada-s-ai Bot commented Nov 19, 2026
Copy link
Copy Markdown
Author

CI fix handover (CMake Clang red)

  • Cause: not this PR's code. The windows-2025-vs2026 runner image is rolling out MSVC 14.52, whose STL rejects the image's LLVM 20.1.8 (STL1000: expected Clang 22 or newer). Runners on image 20261116.x fail; runners on 20261103.x (MSVC 14.51) pass. zdxsv-master failed the same way (Windows Builds runs at 04:44 and 06:41 UTC).
  • Fix: CI CMake Clang: use Visual Studio's clang-cl, which its STL accepts #701 builds CMake Clang with Visual Studio's bundled clang-cl. Verified only with actionlint; its own CI is the first real run. The release workflow builds the player binary with this job, so I left the merge to the owner.
  • This PR: failed job re-run (it passes if it lands on an old-image runner). After PR 701 merges, a re-run picks up the fix (PR CI builds the merge with zdxsv-master); no rebase needed.
  • If PR 701's CMake Clang still fails: the bundled clang is also too old. Next fallback: add -D_ALLOW_COMPILER_AND_STL_VERSION_MISMATCH to the CMake Clang cmakeFlags, or install LLVM 22 in the job.
  • @inada-s: merge CI CMake Clang: use Visual Studio's clang-cl, which its STL accepts #701.

Status: waiting

@inada-s
inada-s merged commit 867242c into zdxsv-master Nov 19, 2026
6 of 7 checks passed
@inada-s
inada-s deleted the ai/zdxsv-signout-all branch November 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0