Repository navigation
zdxsv spectate sync: Zdxsv namespace instead of a nested one - #697
Merged
Merged
Conversation
…a nested namespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Four-screen replay sync moves from the nested
Zdxsv::SpectateSyncnamespace intoZdxsv: functions get aSpectateSyncprefix (SpectateSyncJoin, ...),ControlbecomesSpectateSyncControl,SLACK/GRIDbecomeSPECTATE_SYNC_SLACK/SPECTATE_SYNC_GRID. Rename only, no behavior change.Rationale behind Changes
AGENTS.md Fork Rules: one namespace,
Zdxsv, nothing nested.Suggested Testing Steps
FOUR=1 rplay.pyon a 2-player replay: PASS, spread max 2 frames, guest trace 0 mismatches (Windows x64 Release, private rig). Not built on Linux, macOS or arm64.Did you use AI to help find, test, or implement this issue or feature?
Yes: an AI agent made the rename and ran the test.