8000 zdxsv optest compares: exit 1 when a case differs by inada-s-ai[bot] · Pull Request #691 · inada-s/pcsx2 · GitHub
[go: up one dir, main page]

Skip to content

zdxsv optest compares: exit 1 when a case differs - #691

Merged
inada-s merged 1 commit into
zdxsv-masterfrom
ai/optest-cmp-exit
Nov 19, 2026
Merged

inada-s merged 1 commit into
zdxsv-masterfrom
ai/optest-cmp-exit

Conversation

@inada-s-ai
@inada-s-ai inada-s-ai Bot commented Nov 18, 2026
Copy link
Copy Markdown

Description of Changes

ee_optest_cmp.py and vu1_optest_cmp.py exit 1 (FAIL N cases differ) when any case differs. vu1_optest_cmp.py also refuses files whose sizes do not match the ops in the log, and an empty log, and counts differing cases instead of the largest per-output count.

Rationale behind Changes

Both printed the differences and exited 0, so the "FPU and VU math as x86" test in tests/zdxsv/README.md (pass: no op differs) could not fail. The VU1 compare also passed when the log had no ops.

Suggested Testing Steps

Crafted files (one op, 2 cases, one output word changed in b), verified locally on windows-mini:

  • before: same 0, differ 0, VU1 empty log 0
  • after: same 0, differ 1, VU1 empty log 1, VU1 short file 1
    Not run on real optest files from an ARM64 and an x86_64 build (the record size check matches the VuOpTest.cpp writer, 35 + 41 words per case).

Did you use AI to help find, test, or implement this issue or feature?

Yes: found, written and checked by an AI agent (Claude Code).

🤖 Generated with Claude Code

@inada-s
inada-s merged commit f99a92f into zdxsv-master Nov 19, 2026
3 of 4 checks passed
@inada-s
inada-s deleted the ai/optest-cmp-exit branch November 19, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0