Repository navigation
zdxsv optest compares: exit 1 when a case differs - #691
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
ee_optest_cmp.pyandvu1_optest_cmp.pyexit 1 (FAIL N cases differ) when any case differs.vu1_optest_cmp.pyalso refuses files whose sizes do not match the ops in the log, and an empty log, and counts differing cases instead of the largest per-output count.Rationale behind Changes
Both printed the differences and exited 0, so the "FPU and VU math as x86" test in
tests/zdxsv/README.md(pass: no op differs) could not fail. The VU1 compare also passed when the log had no ops.Suggested Testing Steps
Crafted files (one op, 2 cases, one output word changed in b), verified locally on windows-mini:
Not run on real optest files from an ARM64 and an x86_64 build (the record size check matches the
VuOpTest.cppwriter, 35 + 41 words per case).Did you use AI to help find, test, or implement this issue or feature?
Yes: found, written and checked by an AI agent (Claude Code).
🤖 Generated with Claude Code