Repository navigation
zdxsv rig tests: README rows named after features.md, checked in CI - #690
Merged
Merged
Conversation
…y featurecheck.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
tests/zdxsv/README.md: every "Tests per feature" row's Feature cell is now adocs/zdxsv/features.mdname, alone or asName: scenario(47 rows renamed, aVSync on by default"no test" row added, an unescaped|that split a table row escaped).tests/zdxsv/featurecheck.py(stdlib): fails on a row that names no feature and on a feature with no row ("Upstream fixes" skipped). Run in the Windows workflow's lint job.Rationale behind Changes
12 features had no row and about 50 rows named no feature, so "which features have no test" could not be answered from the documents.
Suggested Testing Steps
python tests/zdxsv/featurecheck.py: exit 0. Run on the old README (features.md unchanged): 61 mismatches, exit 1.Verified locally on windows-mini (both runs above; the merge with PR 674 and PR 679 also passes). The new CI step has not run yet. PR 662 adds a row named
Refused token (401): whichever merges second renames it, e.g.Fast login: refused token (401).Did you use AI to help find, test, or implement this issue or feature?
Yes: written and checked by an AI agent (Claude Code).
🤖 Generated with Claude Code